Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Fix integration tests #804

Closed
wants to merge 3 commits into from
Closed

test: Fix integration tests #804

wants to merge 3 commits into from

Conversation

sbouchet
Copy link
Contributor

@sbouchet sbouchet commented Apr 14, 2023 •
edited by fbricon
Loading

Fixes #831

@sbouchet sbouchet changed the title Update build.gradle test: Fix integration tests Apr 14, 2023
@sbouchet sbouchet marked this pull request as draft April 14, 2023 13:22
@sbouchet
fix: fix tests
4e4aaf7 
Signed-off-by: Stephane Bouchet <[email protected]>
@sonarcloud
Copy link

sonarcloud bot commented Apr 14, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@fbricon
Copy link
Contributor

fbricon commented May 22, 2023

https://github.com/redhat-developer/intellij-quarkus/actions/workflows/itests.yml was disabled until someone fixes the ITs

On my machine and this PR, they fail with

> Task :integrationTest

OpenJDK 64-Bit Server VM warning: Option UseConcMarkSweepGC was deprecated in version 9.0 and will likely be removed in a future release.

  SLF4J: Class path contains multiple SLF4J bindings.
  SLF4J: Found binding in [jar:file:/Users/fbricon/.gradle/caches/modules-2/files-2.1/com.jetbrains.intellij.idea/ideaIC/2020.3/22cef0fc611e4b9642a48bc955b2b7aacb13bd4d/ideaIC-2020.3/plugins/maven/lib/maven36-server-impl.jar!/org/slf4j/impl/StaticLoggerBinder.class]
  SLF4J: Found binding in [jar:file:/Users/fbricon/.gradle/caches/modules-2/files-2.1/com.jetbrains.intellij.idea/ideaIC/2020.3/22cef0fc611e4b9642a48bc955b2b7aacb13bd4d/ideaIC-2020.3/lib/slf4j-log4j12-1.7.25.jar!/org/slf4j/impl/StaticLoggerBinder.class]
  SLF4J: See http://www.slf4j.org/codes.html#multiple_bindings for an explanation.
  SLF4J: Actual binding is of type [org.jetbrains.idea.maven.server.Maven3WrapperSl4LoggerFactory]

org.jboss.tools.intellij.quarkus.tests.BasicTest

  Test initializationError FAILED

  com.intellij.remoterobot.utils.WaitForConditionTimeoutException: Exceeded timeout (PT2S) for condition function (Failed to find 'Container' by '//div[@class='DialogPanel']' in 2s)
      at app//com.intellij.remoterobot.utils.RepeatUtilsKt.waitFor(RepeatUtils.kt:50)
      at app//com.intellij.remoterobot.utils.RepeatUtilsKt.waitFor$default(RepeatUtils.kt:36)
      at app//com.intellij.remoterobot.SearchContext$find$1.invoke(SearchContext.kt:53)
      at app//com.intellij.remoterobot.SearchContext$find$1.invoke(SearchContext.kt:51)
      at app//com.intellij.remoterobot.stepsProcessing.StepWorkerKt.step(StepWorker.kt:23)
      at app//com.intellij.remoterobot.SearchContext$DefaultImpls.find(SearchContext.kt:51)
      at app//com.intellij.remoterobot.RemoteRobot.find(RemoteRobot.kt:32)
      at app//com.intellij.remoterobot.SearchContext$DefaultImpls.find(SearchContext.kt:45)
      at app//com.intellij.remoterobot.RemoteRobot.find(RemoteRobot.kt:32)
      at app//com.redhat.devtools.intellij.commonuitest.fixtures.dialogs.FlatWelcomeFrame.openSettingsDialog(FlatWelcomeFrame.java:149)
      at app//com.redhat.devtools.intellij.commonuitest.fixtures.dialogs.FlatWelcomeFrame.disableNotifications(FlatWelcomeFrame.java:186)
      at app//org.jboss.tools.intellij.quarkus.tests.AbstractQuarkusTest.startIntelliJ(AbstractQuarkusTest.java:41)
      at [email protected]/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
      at [email protected]/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
      at [email protected]/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
      at [email protected]/java.lang.reflect.Method.invoke(Method.java:566)
      at app//org.junit.platform.commons.util.ReflectionUtils.invokeMethod(ReflectionUtils.java:515)
      at app//org.junit.jupiter.engine.execution.ExecutableInvoker.invoke(ExecutableInvoker.java:115)
      at app//org.junit.jupiter.engine.descriptor.ClassTestDescriptor.lambda$invokeBeforeAllMethods$8(ClassTestDescriptor.java:373)
      at app//org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:72)
      at app//org.junit.jupiter.engine.descriptor.ClassTestDescriptor.invokeBeforeAllMethods(ClassTestDescriptor.java:372)
      at app//org.junit.jupiter.engine.descriptor.ClassTestDescriptor.before(ClassTestDescriptor.java:201)
      at app//org.junit.jupiter.engine.descriptor.ClassTestDescriptor.before(ClassTestDescriptor.java:74)
      at app//org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$5(NodeTestTask.java:102)
      at app//org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:72)
      at app//org.junit.platform.engine.support.hierarchical.NodeTestTask.executeRecursively(NodeTestTask.java:95)
      at app//org.junit.platform.engine.support.hierarchical.NodeTestTask.execute(NodeTestTask.java:71)
      at [email protected]/java.util.ArrayList.forEach(ArrayList.java:1541)
      at app//org.junit.platform.engine.support.hierarchical.SameThreadHierarchicalTestExecutorService.invokeAll(SameThreadHierarchicalTestExecutorService.java:38)
      at app//org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$5(NodeTestTask.java:110)
      at app//org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:72)
      at app//org.junit.platform.engine.support.hierarchical.NodeTestTask.executeRecursively(NodeTestTask.java:95)
      at app//org.junit.platform.engine.support.hierarchical.NodeTestTask.execute(NodeTestTask.java:71)
      at app//org.junit.platform.engine.support.hierarchical.SameThreadHierarchicalTestExecutorService.submit(SameThreadHierarchicalTestExecutorService.java:32)
      at app//org.junit.platform.engine.support.hierarchical.HierarchicalTestExecutor.execute(HierarchicalTestExecutor.java:57)
      at app//org.junit.platform.engine.support.hierarchical.HierarchicalTestEngine.execute(HierarchicalTestEngine.java:51)
      at org.junit.platform.launcher.core.EngineExecutionOrchestrator.execute(EngineExecutionOrchestrator.java:107)
      at org.junit.platform.launcher.core.EngineExecutionOrchestrator.execute(EngineExecutionOrchestrator.java:88)
      at org.junit.platform.launcher.core.EngineExecutionOrchestrator.lambda$execute$0(EngineExecutionOrchestrator.java:54)
      at org.junit.platform.launcher.core.EngineExecutionOrchestrator.withInterceptedStreams(EngineExecutionOrchestrator.java:67)
      at org.junit.platform.launcher.core.EngineExecutionOrchestrator.execute(EngineExecutionOrchestrator.java:52)
      at org.junit.platform.launcher.core.DefaultLauncher.execute(DefaultLauncher.java:114)
      at org.junit.platform.launcher.core.DefaultLauncher.execute(DefaultLauncher.java:86)
      at org.junit.platform.launcher.core.DefaultLauncherSession$DelegatingLauncher.execute(DefaultLauncherSession.java:86)
      at org.junit.platform.launcher.core.SessionPerRequestLauncher.execute(SessionPerRequestLauncher.java:53)
      at org.gradle.api.internal.tasks.testing.junitplatform.JUnitPlatformTestClassProcessor$CollectAllTestClassesExecutor.processAllTestClasses(JUnitPlatformTestClassProcessor.java:99)
      at org.gradle.api.internal.tasks.testing.junitplatform.JUnitPlatformTestClassProcessor$CollectAllTestClassesExecutor.access$000(JUnitPlatformTestClassProcessor.java:79)
      at org.gradle.api.internal.tasks.testing.junitplatform.JUnitPlatformTestClassProcessor.stop(JUnitPlatformTestClassProcessor.java:75)
      at org.gradle.api.internal.tasks.testing.SuiteTestClassProcessor.stop(SuiteTestClassProcessor.java:62)
      at [email protected]/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
      at [email protected]/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
      at [email protected]/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
      at [email protected]/java.lang.reflect.Method.invoke(Method.java:566)
      at org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:36)
      at org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24)
      at org.gradle.internal.dispatch.ContextClassLoaderDispatch.dispatch(ContextClassLoaderDispatch.java:33)
      at org.gradle.internal.dispatch.ProxyDispatchAdapter$DispatchingInvocationHandler.invoke(ProxyDispatchAdapter.java:94)
      at com.sun.proxy.$Proxy5.stop(Unknown Source)
      at org.gradle.api.internal.tasks.testing.worker.TestWorker$3.run(TestWorker.java:193)
      at org.gradle.api.internal.tasks.testing.worker.TestWorker.executeAndMaintainThreadName(TestWorker.java:129)
      at org.gradle.api.internal.tasks.testing.worker.TestWorker.execute(TestWorker.java:100)
      at org.gradle.api.internal.tasks.testing.worker.TestWorker.execute(TestWorker.java:60)
      at org.gradle.process.internal.worker.child.ActionExecutionWorker.execute(ActionExecutionWorker.java:56)
      at org.gradle.process.internal.worker.child.SystemApplicationClassLoaderWorker.call(SystemApplicationClassLoaderWorker.java:113)
      at org.gradle.process.internal.worker.child.SystemApplicationClassLoaderWorker.call(SystemApplicationClassLoaderWorker.java:65)
      at app//worker.org.gradle.process.internal.worker.GradleWorkerMain.run(GradleWorkerMain.java:69)
      at app//worker.org.gradle.process.internal.worker.GradleWorkerMain.main(GradleWorkerMain.java:74)

Might be an issue with com.redhat.devtools.intellij:intellij-common-ui-test-library:0.2.0 (0.2.1-SNAPSHOT yields the same results).

@olkornii can you take it over pretty please?

@olkornii
Copy link
Contributor

@fbricon Hi, I can look, but not earlier than in 2 weeks. We have JBT release this and next week.

@sonarcloud
Copy link

sonarcloud bot commented Jul 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@olkornii olkornii self-assigned this Oct 18, 2023
@olkornii olkornii added the tests Testing related issue label Oct 18, 2023
@olkornii
Copy link
Contributor

There are few issues/bugs:

  1. version declaration has been changed: https://github.com/redhat-developer/intellij-quarkus/blob/main/gradle.properties#L12-L13
    previously:
    ideaVersion = IC-2022.2
  2. https://github.com/redhat-developer/intellij-quarkus/blob/main/src/it/java/org/jboss/tools/intellij/quarkus/tests/BasicTest.java#L57 need to rework, new intellij has another label.
  3. https://github.com/redhat-developer/intellij-quarkus/blob/main/src/it/java/org/jboss/tools/intellij/quarkus/tests/BasicTest.java#L58 also need to rework, does not work as expected.
  4. https://github.com/redhat-developer/intellij-quarkus/blob/main/src/it/java/org/jboss/tools/intellij/quarkus/tests/BasicTest.java#L67 sometimes doesn't work. Idea: add "select" before "double click".
  5. https://github.com/redhat-developer/intellij-quarkus/blob/main/src/it/java/org/jboss/tools/intellij/quarkus/tests/BasicTest.java#L103 sometimes doesn't work. Idea: add QuarkusNewProjectThirdPage class, wait for it and then click "next".

@fbricon
Copy link
Contributor

fbricon commented Jul 4, 2024

Superseded by #1349

@fbricon fbricon closed this Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adietish adietish Awaiting requested review from adietish

@angelozerr angelozerr Awaiting requested review from angelozerr

Assignees

@olkornii olkornii

Labels
do-not-merge/work-in-progress tests Testing related issue
Projects
IDE Cloudaptors
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix integration Tests
3 participants
@sbouchet @fbricon @olkornii